Cleanup: Remove setWatermarks(low,high).#16307
Merged
antoniovicente merged 2 commits intoenvoyproxy:mainfrom May 5, 2021
Merged
Cleanup: Remove setWatermarks(low,high).#16307antoniovicente merged 2 commits intoenvoyproxy:mainfrom
antoniovicente merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
/assign @antoniovicente As we discussed here: #16218 (comment) |
Contributor
|
cc @alyssawilk Thanks for the cleanup. Looks good, waiting for CI to complete before approving. |
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Contributor
Author
|
multiplexed_integration tests seem to be fairly flakey under tsan (even running from main branch). This PR shouldn't really effect that. Re-kicking 🤞 /retest |
|
Retrying Azure Pipelines: |
antoniovicente
approved these changes
May 5, 2021
Contributor
antoniovicente
left a comment
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the cleanup.
gokulnair
pushed a commit
to gokulnair/envoy
that referenced
this pull request
May 6, 2021
…#16307) Signed-off-by: Kevin Baichoo <kbaichoo@google.com> Signed-off-by: Gokul Nair <gnair@twitter.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Remove setWatermarkers(low,high).
Additional Description: The driving motivation behind this is due to #16218 (comment).
setWatermark(low,high)is only used for low = high / 2 which the single arg version exposes.Risk Level: low
Testing: Changed tests
Docs Changes: na
Release Notes: na
Platform Specific Features:
Related Issue #15791